Masuda method is still the best for reliably getting a shiny with optimal stats and egg moves it can take hundreds of eggs but you get perfect competitive shinies and a large overstock that can be traded off